Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload volume tasks #4565

Merged
merged 10 commits into from
Apr 29, 2020
Merged

Upload volume tasks #4565

merged 10 commits into from
Apr 29, 2020

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Apr 23, 2020

URL of deployed dev instance (used for testing):

Steps to test:

  • Upload a single zip containing multiple volume zips (e.g. project download)
  • Should create as many tasks as included volume zips

Issues:


@youri-k youri-k self-assigned this Apr 23, 2020
@youri-k youri-k requested a review from fm3 April 23, 2020 12:53
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 🎉 Didn’t expect this to be so small a code change! Please add a changelog entry and this should be ready to go.

@youri-k
Copy link
Contributor Author

youri-k commented Apr 24, 2020

I just noticed that hybrid tasks aren't fully supported, yet. I'll do this today...

@youri-k
Copy link
Contributor Author

youri-k commented Apr 24, 2020

Update is done. I tested it locally. Maybe you could do another check and after that I think, it's good to go live.

@fm3
Copy link
Member

fm3 commented Apr 24, 2020

I’ll have another look today :) let’s wait until monday with merging, though

Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, much better :)

One more thing I noticed: do you think it would be possible to pass the errors from task type checking to the next step, rather than failing hard, so that the user can get the “6 tasks failed” report popup rather than an error toast if there is a mismatch? I’d suggest tackling that in a future Issue/PR, though.

@youri-k
Copy link
Contributor Author

youri-k commented Apr 29, 2020

Yeah, I'll open an issue

@youri-k youri-k merged commit c8c0c85 into master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow creating multiple volume tasks from zipfile
2 participants