-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload volume tasks #4565
Upload volume tasks #4565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! 🎉 Didn’t expect this to be so small a code change! Please add a changelog entry and this should be ready to go.
I just noticed that hybrid tasks aren't fully supported, yet. I'll do this today... |
Update is done. I tested it locally. Maybe you could do another check and after that I think, it's good to go live. |
I’ll have another look today :) let’s wait until monday with merging, though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, much better :)
One more thing I noticed: do you think it would be possible to pass the errors from task type checking to the next step, rather than failing hard, so that the user can get the “6 tasks failed” report popup rather than an error toast if there is a mismatch? I’d suggest tackling that in a future Issue/PR, though.
Yeah, I'll open an issue |
URL of deployed dev instance (used for testing):
Steps to test:
Issues: