Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup old datasource-properties upon change #4534

Merged
merged 4 commits into from
Apr 9, 2020
Merged

Backup old datasource-properties upon change #4534

merged 4 commits into from
Apr 9, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 9, 2020 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • edit datasource properties via wK (i.e. using the dataset edit page)
  • backup log text file should be created

Issues:

  • Updated changelog
  • Needs datastore update after deployment
  • Ready for review

@fm3 fm3 added the backend label Apr 9, 2020
@fm3 fm3 self-assigned this Apr 9, 2020
@fm3 fm3 requested a review from youri-k April 9, 2020 08:29
youri-k
youri-k approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 merged commit b83cb5b into master Apr 9, 2020
@fm3 fm3 deleted the backup-datasource-properties branch April 9, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when overwriting datasource-properties.json, backup old version
2 participants
@fm3 @youri-k