Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task configurations download as csv #4491
Add task configurations download as csv #4491
Changes from 10 commits
48e030d
6f6d1f2
ca8a76b
a59ae26
2109ca0
42ead79
72b6d97
bac5c4e
09b17fb
f3c8d7a
3956507
fd32d4d
43a3c15
9973d16
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subsequentMethod
is quite an unusual name, in my opinion. I'd go withonFinish
,onFinishCallback
oronFinishFunction
instead. Also, the method name can remain athandleFormSubmit
, since the method name doesn't need to explain its parameters.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you noticed correctly, I had problems with finding a good naming here. 😕
The reason why I renamed the
handleFormSubmit
method is, that this name was already used in line 142.But in my opinion, the naming should be fine now in the newest changes. 👍