Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix float histograms #4475

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Fix float histograms #4475

merged 2 commits into from
Mar 17, 2020

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Mar 12, 2020

  • fix rounding of floats and remove wrong implementations

Steps to test:

  • generating a histogram for every float layer should work

Issues:

@youri-k youri-k requested review from normanrz and fm3 March 12, 2020 08:57
@youri-k youri-k self-assigned this Mar 12, 2020
@fm3 fm3 merged commit 6e91a48 into master Mar 17, 2020
@fm3 fm3 deleted the fix-float-rounding branch March 17, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

@normanrz normanrz normanrz approved these changes

Assignees

@youri-k youri-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArrayIndexOutOfBoundsException in histogram call for uint16 layer
3 participants
@youri-k @normanrz @fm3