Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix renaming of annotations in tracing view #4416

Merged
merged 3 commits into from
Jan 27, 2020
Merged

Fix renaming of annotations in tracing view #4416

merged 3 commits into from
Jan 27, 2020

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Jan 24, 2020 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • try to edit name of annotation in tracing view
  • old name should be the default

Issues:

@youri-k youri-k requested a review from philippotto January 24, 2020 10:25
@youri-k youri-k self-assigned this Jan 24, 2020
philippotto
philippotto approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

jstriebel
jstriebel reviewed Jan 27, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@bulldozer-boy bulldozer-boy bot merged commit b69e7f3 into master Jan 27, 2020
@bulldozer-boy bulldozer-boy bot deleted the fix-renaming-of-annotation branch January 27, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstriebel jstriebel jstriebel left review comments

@philippotto philippotto philippotto approved these changes

Assignees

@youri-k youri-k

Labels
automerge frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

editing annotation name: textfield should contain old name
3 participants
@youri-k @philippotto @jstriebel