New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shared teams error for read only tracings #4411

Merged

fm3 merged 3 commits into master from fix-shared-teams-read-only-tracings

Jan 23, 2020

Contributor

youri-k commented Jan 17, 2020 •

edited by daniel-wer

Loading

URL of deployed dev instance (used for testing):

https://fixsharedteamsreadonlytracings.webknossos.xyz

Steps to test:

open read-only tracing
no error show toast should be shown

Issues:

fixes "You are not authorized to view or edit this resource" Toast in read-only tracings #4384

Updated changelog
~~[ ] Updated migration guide if applicable~~
~~[ ] Updated documentation if applicable~~
~~[ ] Adapted wk-connect if datastore API changes~~
~~[ ] Needs datastore update after deployment~~
Ready for review


          surpress error toast for shared teams

4a9deee

youri-k added the frontend label

youri-k requested review from daniel-wer and philippotto

January 17, 2020 13:26

youri-k self-assigned this


          update changelog

7f34b64

daniel-wer approved these changes

View reviewed changes

Member

daniel-wer left a comment

Nice, LGTM 👍


          Merge branch 'master' into fix-shared-teams-read-only-tracings

49796dc

fm3 merged commit 7131077 into master

fm3 deleted the fix-shared-teams-read-only-tracings branch

January 23, 2020 09:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels