Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message if no mag dir was found #4389

Merged
merged 6 commits into from
Jan 9, 2020

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Dec 20, 2019

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • try importing a dataset with missing mag dir
    => error
  • try importing a dataset with mag dir
    => success

Issues:


@youri-k youri-k requested a review from fm3 December 20, 2019 15:17
@youri-k youri-k self-assigned this Dec 20, 2019
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the liberty to slightly change the wording. If that is ok for you, feel free to go ahead with the PR :)

@youri-k youri-k merged commit 743fe26 into master Jan 9, 2020
@fm3 fm3 deleted the dataset-import-error-message branch March 20, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message for importing a dataset with missing mag dir
2 participants