Better default value for upper limit of intenstity range for uint16 layers #4381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBuessemeyer
requested review from
philippotto and
normanrz
and removed request for
philippotto
…her-histogramm-range-uint16
MichaelBuessemeyer
requested review from
philippotto
and removed request for
normanrz
philippotto
reviewed
Jan 6, 2020
frontend/javascripts/oxalis/view/settings/dataset_settings_view.js
Outdated
Show resolved
Hide resolved
|
@philippotto Could you please re-review my code? Thanks :) |
philippotto
reviewed
Jan 13, 2020
frontend/javascripts/oxalis/model/accessors/dataset_accessor.js
Outdated
Show resolved
Hide resolved
philippotto
reviewed
Jan 13, 2020
frontend/javascripts/oxalis/view/settings/dataset_settings_view.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/settings/dataset_settings_view.js
Outdated
Show resolved
Hide resolved
…inds/webknossos into higher-histogramm-range-uint16
|
@philippotto Could you please check my PR again? I just checked the data types |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default intensity range for uint16 data layers to the interval [0, 65535]. Previously it was [0, 255], causing uint16 data layers to be almost completely white by default. Now the data of uint16 layers should be visible by default.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment