Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always activate group after creating it #4282

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Always activate group after creating it #4282

merged 2 commits into from
Sep 16, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Sep 12, 2019 •
edited
Loading

After creating a new group, it should always be selected (no trees should be selected).
I also made the wording in the "delete tree group" modal a bit more concise.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • I created a new group and ensured that it's activated and no other tree is activated
  • I also tested multi-selecting trees and created a group -> in that case, the tree selection should also be cleared

Issues:

@philippotto philippotto self-assigned this Sep 12, 2019
@philippotto philippotto requested a review from fm3 September 16, 2019 07:47
fm3
fm3 approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :-) Also I like the simplified dialog

frontend/javascripts/oxalis/view/right-menu/delete_group_modal_view.js
</Button>,
<Button key="submit-groups-only" type="primary" onClick={onJustDeleteGroup}>
Remove group only
Remove group and keep children
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bulldozer-boy bulldozer-boy bot merged commit 7708a79 into master Sep 16, 2019
@bulldozer-boy bulldozer-boy bot deleted the create-and-activate-group branch September 16, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

@MichaelBuessemeyer MichaelBuessemeyer Awaiting requested review from MichaelBuessemeyer

Assignees

@philippotto philippotto

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @fm3