billed time in project progress view #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichaelBuessemeyer The backend now reports |
|
@fm3 the backend should be ready to review 🙂 |
…bleminds/webknossos into billed-hours-project-progress-view
|
@daniel-wer Could you please review the frontend part? |
daniel-wer
approved these changes
Aug 23, 2019
| title="Time [h]" | ||
| dataIndex="billedMilliseconds" | ||
| sorter={Utils.compareBy(typeHint, project => project.billedMilliseconds)} | ||
| render={number => Utils.millisecondsToHours(number).toLocaleString()} |
There was a problem hiding this comment.
toLocaleString seems to show up to three decimal places by default. Although the original request was to floor this number, I see a benefit in seeing a decimal place. Three may be a bit too much, but you can supply some options to toLocaleString, I'd go with 1 or 2: .toLocaleString(undefined, { maximumFractionDigits: 1}) :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment