Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cheap uint64 support for segmentation layer #4233

Merged
merged 3 commits into from
Aug 21, 2019
Merged

cheap uint64 support for segmentation layer #4233

merged 3 commits into from
Aug 21, 2019

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Aug 15, 2019 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • add dataset with uint64 layer
  • frontend should report a uint32 layer and watching it should be possible

Issues:

@youri-k youri-k requested a review from fm3 August 15, 2019 09:11
@youri-k youri-k self-assigned this Aug 15, 2019
fm3
fm3 approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice solution :) Please add a changelog entry, then this should be good to go

@youri-k youri-k merged commit 5161676 into master Aug 21, 2019
@fm3 fm3 deleted the cheap-uint64-support branch March 20, 2020 08:56
@youri-k youri-k mentioned this pull request May 7, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@youri-k youri-k

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cheap support for uint64 segmentations
2 participants
@youri-k @fm3