-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Histogram followup #4195
Histogram followup #4195
Conversation
@daniel-wer could you do the necessary frontend changes? Please note that the json keys slightly changed and that the backend now always sends an array of histograms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/FindDataService.scala
Outdated
Show resolved
Hide resolved
…sos into histogram-followup
@philippotto Frontend should be ready for review. I updated the data_types Dataset to contain a properly scaled uint16 layer now (with values from 0 to @youri-k Could you also download the updated dataset and have a look at the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Code looks good 👍 The histogram for the RGB dataset might be a bit too overwhelming, but I think it's fine for this iteration.
Sorry, I had the strong urge to scratch the itch coming from #4129. I pushed a small commit to this PR to resolve this. @MichaelBuessemeyer I hope you didn't do this already somewhere else. I wasn't aware that you were assigned to this. Sorry again!
@philippotto It did not work on #4129 yet. Thanks for already solving this issue 🙂. |
URL of deployed dev instance (used for testing):
Steps to test:
float
layer => response json should containmin, max
entriesuint24
layer => response json should contain 3 histograms for each channelIssues: