Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirection when registering for existing organization which has autoVerify=true #3984

Merged
merged 4 commits into from
Apr 4, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Apr 3, 2019

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • needs to be tested locally
  • set autoverify=true for an organization
  • use onboarding flow, select that organization, click "join", and register --> you should be redirected to the dashboard
  • when using the onboarding flow to create a new organization, everything should work as usual

Issues:


@philippotto philippotto self-assigned this Apr 3, 2019
@philippotto philippotto requested a review from daniel-wer April 3, 2019 14:05
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! One could also think about fixing this in the router.js with a <Redirect ..., but this works equally well I'd say :)

@philippotto
Copy link
Member Author

One could also think about fixing this in the router.js with a <Redirect ...,

That was my first try, but then the onboarding flow couldn't be completed, because store changes (e.g., change of active use), triggered a re-render in the router which led to an early redirect. So, I had to use the explicit componentDidMount lifecycle :)

@philippotto philippotto merged commit 45b40e1 into master Apr 4, 2019
@normanrz normanrz deleted the fix-redirect-after-register branch August 12, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboarding is broken for "Demo Lab"
2 participants