-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline UI and allow embedding in iframes #3885
Conversation
@daniel-wer Maybe you can have a look at https://www.playframework.com/documentation/ja/2.3.x/SecurityHeaders to see whether we should keep some of these security measures? |
…e space efficient; should work on smaller devices)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible PR! I love how much thought you put into every single part of this, very well executed! 🏆
I can assure, opening up the "old" version of wK in a few weeks will be very strange (it already is for me, and I only reviewed this PR ^^), this is just so much better 👍
Things I noticed during testing:
-
The spinner and percentage when saving large update actions no longer have a margin and are too close together.
-
The Dasboard Icon does not show a title/tooltip when hovering.
-
The highlighting of the visited sub page for the admin pages doesn't seem to work, "Dashboard" is always highlighted for me, regardless of whether I'm looking at statistics or task types pages, etc...
-
The version restore view is a little too large at the top / the navbar is too tall when being logged out
-
When logged out and looking at a tmpscratch dataset, the tmpscratch and anonymous user avatar are too close together
-
What would be a good way to test the iframe-embeddability? Should we include a test .html page in the repo, which can simply be opened?
-
I don't think this has been introduced in this PR, but some of the buttons in the action bar are rerendered in every frame when brushing in a volume tracing. I originally noticed this, because I thought brushing felt a little sluggish and then used the React Dev Tools - Highlight Updates to visualize. We should optimize this in another PR :)
webknossos-datastore/app/com/scalableminds/webknossos/datastore/Filters.scala
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/layouting/default_layout_configs.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/layouting/tracing_layout_view.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/layouting/tracing_layout_view.js
Outdated
Show resolved
Hide resolved
Thanks for your thorough feedback! I think the PR is good to go now. Will probably merge tomorrow morning. |
@daniel-wer If you give your official approval, I'd merge this :) |
tldr:
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
Screenshots
For small devices:
[ ] Updated documentation if applicable(I created the follow-up issue Update Screenshots in Documentation #3912 for that)