Fix timeline chart by explicitly setting start and end time #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
approved these changes
Feb 14, 2019
| options={{ timeline: { singleColor: "#108ee9" } }} | ||
| options={{ | ||
| timeline: { singleColor: "#108ee9" }, | ||
| hAxis: { |
There was a problem hiding this comment.
Maybe add a comment here with a reference to this PR? Otherwise, we might forget about it and re-introduce the bug again at some point 🙈
This was referenced Jul 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users with only a single sub-second timerange triggered this bug: google/google-visualization-issues#2269
I fixed it by explicitly setting a start and end time for the timeline start (the range the user selected), which is better than the adaptive start/end from before anyways imo. This way it is easier to see which days the selected tracer actually worked and which not.
I also upgraded the charts lib to v2 (v3 didn't work) to get rid of an old version of react that was included specifically for this lib.
Single Day (which triggered the bug before):
Range:
URL of deployed dev instance (used for testing):
Steps to test:
Issues: