Refactor bucket counting #3750
Merged
Refactor bucket counting #3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
added a commit
that referenced
this pull request
Feb 18, 2019
* allow viewports to be non-quadratic (3D viewport still a bit broken; bucketsPerDim is still quadratic) * zoom into viewports so that data cannot be cropped * fix interactions with 3D viewport * make arbitrary viewport square to avoid scaling problems * fix node selection and other rectangular-viewport-related bugs * fix panning * iterate on brush * fix brush preview * clean up * remove viewport width from info tab view and clean up info tab UI * remove unused constants * use larger viewport area to render more data instead of upscaling data (breaks fallback rendering and mouse interactions) * adapt mouse interactions to true-viewport-scaling; fix fallback rendering; band-aid fix arbitrary viewport zoomstep selection * clean up * disable some CI checks * clean up according to PR feedback * update changelog * clean up * fix scalebars and implement tooltips for complete viewport extent * Refactor bucket counting (#3750) * use bucket picker for counting (orthogonal mode only) * adapt arbitrary bucket pickers to new bucket counting approach * add types for priority queue * remove obsolete comment * fix import * revert not-on-master.sh * remove unnecessary import * fix tests and refactor to remove cyclic dependencies in accessors * extract constant * update screenshots * adapt screenshot view value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calculating how many buckets are needed for a specific mag and zoom value, this PR changes the approach to "just invoke" the right bucket pickers and count the returned bucket set. This PR refactors the bucket pickers so that they only act on bucket addresses as entities (as opposed to actual bucket instances). As a result, the bucket counting for the arbitrary modes is based on the actual bucket picker strategies.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: