Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show task modals in read-only tasks #3724

Merged
merged 3 commits into from
Feb 5, 2019
Merged

Do not show task modals in read-only tasks #3724

merged 3 commits into from
Feb 5, 2019

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Feb 4, 2019 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open a task with taskType A.
  • Open a task with taskType B - a modal informing of the new task type should appear
  • Then finish the task with taskType B and copy the Task ID.
  • Open the Tasks view and search for the Task ID. In the results view, click the + icon to view the individual task instances.
  • You should see your finished task instance, select Actions - View.
  • In the opened tracing view no modals should appear.

Issues:

@daniel-wer daniel-wer self-assigned this Feb 4, 2019
philippotto
philippotto approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@daniel-wer daniel-wer merged commit 9cc6ab4 into master Feb 5, 2019
@daniel-wer daniel-wer deleted the read-only-tasks branch February 5, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@daniel-wer daniel-wer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not show task description/recommended settings in read-only tracings
2 participants
@daniel-wer @philippotto