-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to disable auto saving for layout configs #3620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
the tooltips don't work on the first hovers for me :/ antd is probably not meant for this combination of menu and tooltip
I also thought that they didn't work for me on the first try, but they actually do! The problem seems to be that they only trigger when hovering over the icon, which is quite a bit smaller than the Menu.Item. I didn't find a nice way to add an Antd Tooltip to the Menu.Item, but you could think about adding a title
attribute to the Menu.Item instead of using the Antd Tooltip. This way the tooltips will always be rendered :)
Nice, thanks for the tip! 🎉 |
…/webknossos into optional-layout-autosaving
* allow to disable auto saving for layout configs * tweak layout of layout menu * improve tooltip handling in layout menu
URL of deployed dev instance (used for testing):
Steps to test:
Issues: