Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable auto saving for layout configs #3620

Merged
merged 8 commits into from
Jan 15, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jan 11, 2019

  • implement functionality
  • clean up UI

URL of deployed dev instance (used for testing):

Steps to test:

  • ensure that you have at least two layout presets
  • disable auto-saving by clicking the "disconnect" item in the layout submenu (the tooltips don't work on the first hovers for me :/ antd is probably not meant for this combination of menu and tooltip)
  • change the active layout (e.g., make a pane bigger)
  • switch to the other layout
  • switch to the changed layout (it should not contain the bigger pane)
  • enable auto-saving and repeat the above steps (the layout change should survive the layout switching)

Issues:


@philippotto philippotto self-assigned this Jan 11, 2019
@philippotto philippotto changed the title [WIP] Allow to disable auto saving for layout configs Allow to disable auto saving for layout configs Jan 14, 2019
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

the tooltips don't work on the first hovers for me :/ antd is probably not meant for this combination of menu and tooltip

I also thought that they didn't work for me on the first try, but they actually do! The problem seems to be that they only trigger when hovering over the icon, which is quite a bit smaller than the Menu.Item. I didn't find a nice way to add an Antd Tooltip to the Menu.Item, but you could think about adding a title attribute to the Menu.Item instead of using the Antd Tooltip. This way the tooltips will always be rendered :)

@philippotto
Copy link
Member Author

[...] but you could think about adding a title attribute to the Menu.Item instead of using the Antd Tooltip.

Nice, thanks for the tip! 🎉

@philippotto philippotto merged commit 20c755a into master Jan 15, 2019
daniel-wer pushed a commit that referenced this pull request Jan 29, 2019
* allow to disable auto saving for layout configs

* tweak layout of layout menu

* improve tooltip handling in layout menu
@normanrz normanrz deleted the optional-layout-autosaving branch February 20, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make auto-saving of layout changes optional
2 participants