Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable merger mode in skeleton and hybrid tracings #3619

Merged
merged 38 commits into from
Mar 25, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
8b2753c
added todo notes
MichaelBuessemeyer Nov 30, 2018
24a7444
making srcipt readable
MichaelBuessemeyer Dec 5, 2018
cf557fa
reworked script even more
MichaelBuessemeyer Jan 11, 2019
5fcb63a
integrated merger mode into the ui
MichaelBuessemeyer Jan 11, 2019
cacc165
further refactoring of the merger script: added flow type checking
MichaelBuessemeyer Jan 18, 2019
5ec844f
merged master into this branch and resolved conflicts in user_setting…
MichaelBuessemeyer Jan 18, 2019
1766303
fixed disabling merger mode
MichaelBuessemeyer Jan 18, 2019
f162409
changed pre processing of the merger modeto make it parallel for each…
MichaelBuessemeyer Jan 25, 2019
5e882e9
applied pr feedback
MichaelBuessemeyer Jan 29, 2019
79c5538
applied feedback
MichaelBuessemeyer Jan 30, 2019
8b14aa5
fixed table content to be wrapped with tbody element
MichaelBuessemeyer Feb 1, 2019
9283f63
merged origin/master into enavle-merger-mode-in-hybrid-tracings
MichaelBuessemeyer Feb 1, 2019
0cc3f25
fixed flow complaining
MichaelBuessemeyer Feb 1, 2019
f2be5db
Merge branch 'master' of github.com:scalableminds/webknossos into ena…
philippotto Feb 25, 2019
0122d3c
updated to master
MichaelBuessemeyer Feb 28, 2019
c78f8df
added rough merger mode explaination to docs
MichaelBuessemeyer Feb 28, 2019
d71f312
added changelog entry
MichaelBuessemeyer Feb 28, 2019
4a3b156
added overwrite action that also adjusts the mapping when a whole tre…
MichaelBuessemeyer Feb 28, 2019
0098ad5
Merge branch 'master' into enable-merger-mode-in-hybrid-tracings
MichaelBuessemeyer Feb 28, 2019
c83325c
updated to master and resolved conflicts
MichaelBuessemeyer Mar 11, 2019
59f0753
made code pretty
MichaelBuessemeyer Mar 11, 2019
2453cd4
Merge branch 'master' into enable-merger-mode-in-hybrid-tracings
MichaelBuessemeyer Mar 11, 2019
b100805
Merge branch 'master' of github.com:scalableminds/webknossos into ena…
MichaelBuessemeyer Mar 13, 2019
b7890c6
added isMergerModeEnabeld to temporary store configs
MichaelBuessemeyer Mar 13, 2019
a58d6f5
fixed flow errors
MichaelBuessemeyer Mar 13, 2019
2885fb7
Merge branch 'enable-merger-mode-in-hybrid-tracings' of github.com:sc…
MichaelBuessemeyer Mar 13, 2019
0eeb881
fixed spelling and node prepocessing bug of merger mode
MichaelBuessemeyer Mar 13, 2019
825d5fc
Merge branch 'master' of github.com:scalableminds/webknossos into ena…
MichaelBuessemeyer Mar 13, 2019
6e6865d
Update tracing_ui.md
MichaelBuessemeyer Mar 13, 2019
cb2b65c
Update CHANGELOG.md
MichaelBuessemeyer Mar 21, 2019
60e09c8
Merge branch 'master' into enable-merger-mode-in-hybrid-tracings
MichaelBuessemeyer Mar 21, 2019
6b8d2ba
Merge branch 'master' of github.com:scalableminds/webknossos into ena…
MichaelBuessemeyer Mar 21, 2019
7d3f8b9
disabled merger mode in settings when no uint32 segm is available
MichaelBuessemeyer Mar 21, 2019
86eeec3
disabled merger mode switch when no mappings are supported
MichaelBuessemeyer Mar 25, 2019
d6b7c5b
Merge branch 'master' into enable-merger-mode-in-hybrid-tracings
MichaelBuessemeyer Mar 25, 2019
52093f1
added comment
MichaelBuessemeyer Mar 25, 2019
c946382
Merge branch 'master' of github.com:scalableminds/webknossos into ena…
MichaelBuessemeyer Mar 25, 2019
6140705
Merge branches 'enable-merger-mode-in-hybrid-tracings' and 'enable-me…
MichaelBuessemeyer Mar 25, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 40 additions & 35 deletions frontend/javascripts/oxalis/view/right-menu/mapping_info_view.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ type StateProps = {|
setAvailableMappingsForLayer: (string, Array<string>) => void,
activeViewport: OrthoView,
activeCellId: number,
isMergerModeEnabled: boolean,
|};
type Props = {| ...OwnProps, ...StateProps |};

Expand Down Expand Up @@ -252,44 +253,47 @@ class MappingInfoView extends React.Component<Props, State> {
return (
<div id="volume-mapping-info" className="padded-tab-content" style={{ maxWidth: 500 }}>
{this.renderIdTable()}

<div style={{ marginTop: 24, width: "50%", marginLeft: 16 }}>
<div style={{ marginBottom: 6 }}>
<label className="setting-label">
ID Mapping
<Switch
onChange={this.handleSetMappingEnabled}
checked={this.state.shouldMappingBeEnabled}
style={{ float: "right" }}
loading={this.state.isRefreshingMappingList}
/>
</label>
</div>

{/*
{/* Only display the mapping selection when merger mode is not active
to avoid conflicts in the logic of the UI. */
!this.props.isMergerModeEnabled ? (
<div style={{ marginTop: 24, width: "50%", marginLeft: 16 }}>
<div style={{ marginBottom: 6 }}>
<label className="setting-label">
ID Mapping
<Switch
onChange={this.handleSetMappingEnabled}
checked={this.state.shouldMappingBeEnabled}
style={{ float: "right" }}
loading={this.state.isRefreshingMappingList}
/>
</label>
</div>

{/*
Show mapping-select even when the mapping is disabled but the UI was used before
(i.e., mappingName != null)
*/}
{this.state.shouldMappingBeEnabled || this.props.mappingName != null ? (
<Select
placeholder="Select mapping"
defaultActiveFirstOption={false}
style={{ width: "100%" }}
{...selectValueProp}
onChange={this.handleChangeMapping}
notFoundContent="No mappings found."
>
{availableMappings
.slice()
.sort(Utils.localeCompareBy(([]: Array<string>), mapping => mapping))
.map(mapping => (
<Option key={mapping} value={mapping}>
{mapping}
</Option>
))}
</Select>
) : null}
</div>
{this.state.shouldMappingBeEnabled || this.props.mappingName != null ? (
<Select
placeholder="Select mapping"
defaultActiveFirstOption={false}
style={{ width: "100%" }}
{...selectValueProp}
onChange={this.handleChangeMapping}
notFoundContent="No mappings found."
>
{availableMappings
.slice()
.sort(Utils.localeCompareBy(([]: Array<string>), mapping => mapping))
.map(mapping => (
<Option key={mapping} value={mapping}>
{mapping}
</Option>
))}
</Select>
) : null}
</div>
) : null}
</div>
);
}
Expand Down Expand Up @@ -319,6 +323,7 @@ function mapStateToProps(state: OxalisState) {
activeCellId: getVolumeTracing(state.tracing)
.map(tracing => tracing.activeCellId)
.getOrElse(0),
isMergerModeEnabled: state.temporaryConfiguration.isMergerModeEnabled,
};
}

Expand Down
22 changes: 11 additions & 11 deletions frontend/javascripts/oxalis/view/settings/setting_input_views.js
Original file line number Diff line number Diff line change
Expand Up @@ -152,23 +152,23 @@ export class SwitchSetting extends React.PureComponent<SwitchSettingProps> {

render() {
const { label, onChange, value, disabled, tooltipText } = this.props;
const switchButton = (
<Col span={15}>
<Switch onChange={onChange} checked={value} defaultChecked={value} disabled={disabled} />
</Col>
);
return (
<Row className="margin-bottom" type="flex" align="top">
<Col span={9}>
<label className="setting-label">{label}</label>
</Col>
{tooltipText != null ? (
<Tooltip title={tooltipText} placement="topLeft">
{switchButton}
<Col span={15}>
<Tooltip title={tooltipText} placement="top">
<div style={{ display: "inline-block" }}>
philippotto marked this conversation as resolved.
Show resolved Hide resolved
<Switch
onChange={onChange}
checked={value}
defaultChecked={value}
disabled={disabled}
/>
</div>
</Tooltip>
) : (
switchButton
)}
</Col>
</Row>
);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/**

* tracing_settings_view.js
* @flow
*/
Expand Down Expand Up @@ -302,7 +301,7 @@ class UserSettingsView extends PureComponent<UserSettingsViewProps, State> {
disabled={!isMergerModeSupported}
tooltipText={
!isMergerModeSupported
? "The merger mode is only available for datasets with uint32 segmentations"
? "The merger mode is only available for datasets with uint32 segmentations."
: null
}
/>
Expand Down