Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect resolutions when copying segmentation slice #3245

Merged
merged 3 commits into from
Sep 19, 2018

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Sep 18, 2018

For anisotropic datasets, copying a segmentation slice (via "v") in viewports other than xy didn't work properly. Some voxels outside the visible viewport were copied even though this should not be the case.

URL of deployed dev instance (used for testing):

Steps to test:

  • brush over the edges in yz and xz viewport
  • move to next slice
  • hit "v"
  • move the viewports to see that the brushed segmentation has a hard cut (--> only visible voxels were written)

Issues:


Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, tested and works!

@philippotto philippotto merged commit 6f8b478 into master Sep 19, 2018
@normanrz normanrz deleted the fix-copy-segmentation branch February 20, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy segmentation slice copies data from outside the visible viewport for xz and yz
2 participants