Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button for collapsing all comments #3215

Merged
merged 10 commits into from
Sep 17, 2018
Merged

Add button for collapsing all comments #3215

merged 10 commits into from
Sep 17, 2018

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Sep 13, 2018

Additionally, this PR adds a small description to the markdown modal which explains the linking in comments. I also made the buttons in the comment tab a bit more compact and gave them titles.

URL of deployed dev instance (used for testing):

Steps to test:

  • create nodes with comments
  • use the new button to collapse/expand all tree groups in the comment tab

Issues:


Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

<a href="https://markdown-it.github.io/" target="_blank" rel="noopener noreferrer">
Markdown
</a>{" "}
for formatting, you can also create link to nodes and positions by using hashtags. For
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: link should be linkS

<ButtonComponent
onClick={this.toggleExpandForAllTrees}
icon="shrink"
title="Collapse or expand or groups"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a typo

<Icon type="search" />
</ButtonComponent>
</Tooltip>
<ButtonComponent icon="search" title="Open the search via CTRL + Shift + F" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

@philippotto philippotto merged commit 0a87044 into master Sep 17, 2018
@philippotto philippotto deleted the collapse-comments branch September 18, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button to collapse all comments
2 participants