-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button for collapsing all comments #3215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
<a href="https://markdown-it.github.io/" target="_blank" rel="noopener noreferrer"> | ||
Markdown | ||
</a>{" "} | ||
for formatting, you can also create link to nodes and positions by using hashtags. For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: link should be linkS
<ButtonComponent | ||
onClick={this.toggleExpandForAllTrees} | ||
icon="shrink" | ||
title="Collapse or expand or groups" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a typo
<Icon type="search" /> | ||
</ButtonComponent> | ||
</Tooltip> | ||
<ButtonComponent icon="search" title="Open the search via CTRL + Shift + F" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! :)
Additionally, this PR adds a small description to the markdown modal which explains the linking in comments. I also made the buttons in the comment tab a bit more compact and gave them titles.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: