-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI to restore previous versions of a tracing #3194
Merged
Merged
Changes from 8 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5091391
first working version of tracing version restore
daniel-wer 95f38ec
added types and categorized some update action batches to show better…
daniel-wer 2bc2dcd
Merge branch 'master' of github.com:scalableminds/webknossos into res…
daniel-wer f0277ed
Merge branch 'master' of github.com:scalableminds/webknossos into res…
daniel-wer bc317a4
improve batch description, save before opening version restore view
daniel-wer f8a54f1
rework flow types for ServerUpdateActions
philippotto a5fbd4f
fix missing null checks
philippotto 4505729
only scroll version list in version history view
philippotto c440da3
remove obsolete import
philippotto 2bb3f0c
Merge branch 'master' of github.com:scalableminds/webknossos into res…
daniel-wer cbd75dc
PR feedback #1, show info alert instead of tracing actions
daniel-wer b5179a9
in updateActionLog, annotate batches with version number (#3203)
fm3 5536431
PR feedback #2, scroll into view, descriptions for other update actions
daniel-wer e64b3b7
Merge branch 'master' of github.com:scalableminds/webknossos into res…
daniel-wer f39f289
adapt changelog and docs
daniel-wer 58e57b1
[docs] point to 'restore older version' from redo/undo, fix typo
daniel-wer 5a064e8
Merge branch 'master' of github.com:scalableminds/webknossos into res…
daniel-wer 3e9c150
make version restore view's position fixed, style fixes, allow showVe…
daniel-wer 4f67ffa
Merge branch 'master' into restore-old-versions
daniel-wer d2aad3f
Merge branch 'master' into restore-old-versions
daniel-wer c7187c1
Merge branch 'master' into restore-old-versions
daniel-wer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,11 +6,21 @@ type SetDropzoneModalVisibilityActionType = { | |
visible: boolean, | ||
}; | ||
|
||
export type UiActionType = SetDropzoneModalVisibilityActionType; | ||
type SetVersionRestoreModeActionType = { | ||
type: "SET_VERSION_RESTORE_MODE_ACTION_TYPE", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I see that I used the "_TYPE" suffix in the action constant for |
||
active: boolean, | ||
}; | ||
|
||
export type UiActionType = SetDropzoneModalVisibilityActionType | SetVersionRestoreModeActionType; | ||
|
||
export const setDropzoneModalVisibilityAction = ( | ||
visible: boolean, | ||
): SetDropzoneModalVisibilityActionType => ({ | ||
type: "SET_DROPZONE_MODAL_VISIBILITY_ACTION_TYPE", | ||
visible, | ||
}); | ||
|
||
export const setVersionRestoreModeAction = (active: boolean): SetVersionRestoreModeActionType => ({ | ||
type: "SET_VERSION_RESTORE_MODE_ACTION_TYPE", | ||
active, | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
Mode
? Isn't it only visible/invisible? I'd use visibility then, since mode sounds like there would be different "restore modes".