Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Play security http headers #3084

Merged
merged 5 commits into from
Aug 22, 2018
Merged

Enable Play security http headers #3084

merged 5 commits into from
Aug 22, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 22, 2018

sets security http headers:

X-Frame-Options: DENY
X-Permitted-Cross-Domain-Policies: master-only
X-XSS-Protection: 1; mode=block

(but not the ones that disrupted normal operation: X-Permitted-Cross-Domain-Policies and Content-Security-Policy)

for reference: https://www.playframework.com/documentation/2.4.x/SecurityHeaders

URL of deployed dev instance (used for testing):

Steps to test:

  • react + google analytics should start normally
  • autologin should still work
  • datastore-related requests should not fail (e.g. start a tracing, save some update actions, download nml via backend)

Issues:


  • Updated changelog
  • [ ] Updated migration guide if applicable
  • [ ] Needs datastore update after deployment
  • Ready for review

@fm3 fm3 self-assigned this Aug 22, 2018
@fm3 fm3 requested review from normanrz and daniel-wer August 22, 2018 08:19
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested google analytics, user scripts and update actions, everything working :)

@fm3 fm3 merged commit 4eed783 into master Aug 22, 2018
@fm3 fm3 deleted the xframe branch August 22, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance webknossos security
2 participants