In TaskType list, show Team name again #3053
Conversation
…sos into tasktype-json-team
There was a problem hiding this comment.
Nice, works well :)
@fm3 When creating a task type the team property is still called team which makes for somewhat inconsistent types. I would suggest to rename it to teamId as well. What do you think?
CHANGELOG.md
Outdated
| @@ -45,6 +45,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.md). | |||
| - Fixed that URLs linking to a certain position in a dataset or tracing always led to the position of the active node. [#2960](https://github.com/scalableminds/webknossos/pull/2960) | |||
| - Fixed that setting a bounding box in view mode did not work. [#3015](https://github.com/scalableminds/webknossos/pull/3015) | |||
| - Fixed a bug where viewing Compound Annotations (such as viewing all instances of a task at once) failed with a permission issue. [#3023](https://github.com/scalableminds/webknossos/pull/3023) | |||
| - Fixed a bug where the name was not displayed in the task types view of admins. [#3053](https://github.com/scalableminds/webknossos/pull/3053) | |||
There was a problem hiding this comment.
The word "team" is missing in front of "name was not displayed ...".
…updated snapshots
| @@ -163,6 +163,14 @@ export type APITaskTypeType = { | |||
| +settings: APISettingsType, | |||
| }; | |||
|
|
|||
| export type APICreateTaskType = { | |||
There was a problem hiding this comment.
Let's try to avoid this type code duplication and wait for @fm3 answer :)
There was a problem hiding this comment.
@daniel-wer ok, that was just a quick solution i came up with @philippotto. But your suggestion makes way more sense :)
There was a problem hiding this comment.
I agree, let’s change that to teamId as well, I will do that tomorrow.
| @@ -1,126 +0,0 @@ | |||
| # Snapshot report for `public/test-bundle/test/libs/nml.spec.js` | |||
There was a problem hiding this comment.
You accidentally deleted the NML snapshots, please restore them :)
Good thing is, this won't happen easily again in the future, thanks to @fm3s recent PR (#3052) 🎉
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated migration guide if applicable[ ] Needs datastore update after deployment