Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AnnotationSQL to Annotation. etc. #2979

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Rename AnnotationSQL to Annotation. etc. #2979

merged 2 commits into from
Jul 30, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 30, 2018 •
edited
Loading

follow up for #2521

Steps to test:

  • CI run should be enough, intelliJ should have supported the renaming properly

- [ ] Updated changelog
- [ ] Updated migration guide if applicable

  • Ready for review

@fm3 fm3 self-assigned this Jul 30, 2018
@fm3 fm3 requested review from jstriebel, rschwanhold and youri-k July 30, 2018 10:39
jstriebel
jstriebel approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✏️ 👍

@fm3 fm3 merged commit 3b71b12 into master Jul 30, 2018
@fm3 fm3 deleted the rename-sqldao-classes branch July 30, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstriebel jstriebel jstriebel approved these changes

@rschwanhold rschwanhold Awaiting requested review from rschwanhold

@youri-k youri-k Awaiting requested review from youri-k

Assignees

@fm3 fm3

Labels
backend refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @jstriebel