Send save actions in chunks to server #2947
Conversation
…t once to the server
| return ( | ||
| <ButtonComponent | ||
| key="save-button" | ||
| type="primary" | ||
| onClick={this.props.onClick} | ||
| icon={this.getSaveButtonIcon()} | ||
| > | ||
| Save | ||
| {this.showProgress() ? ( |
There was a problem hiding this comment.
Minor, but would shouldShowProgress be a better name here as the function returns a boolean and doesn't execute an action.
|
|
||
| const trees = generateDummyTrees(1000, 1); | ||
| Store.dispatch(addTreesAndGroupsAction(createTreeMapFromTreeArray(trees), [])); | ||
| // t.true(true); |
| t.is(state.save.queue[0].actions.length, maximumActionCountPerBatch); | ||
| }); | ||
|
|
||
| test.serial("Save actions should be chunked after compacting (2/3)", t => { |
| }); | ||
|
|
||
| test.serial("Save actions should be chunked after compacting (2/3)", t => { | ||
| const nodeCount = 20000; |
There was a problem hiding this comment.
Nice, I was wondering what that parameter was, before :D
| @@ -29,29 +37,55 @@ class SaveButton extends React.PureComponent<Props, State> { | |||
|
|
|||
| savedPollingInterval: number = 0; | |||
| _forceUpdate = () => { | |||
There was a problem hiding this comment.
To get rid of the hourglass icon in the save button that is briefly displayed after saving, although the state was just successfully saved, we could call _forceUpdate after isBusy changed or was set to false (check for that in componentDidUpdate or so). Fine for me anyways, just wanted to mention it :)
There was a problem hiding this comment.
Good point! However, I'd like to postpone this until we get rid of the entire forceUpdate stuff (hopefully soon). It's quite tedious and maybe the flickering hourglass will serve as a reminder for us to improve this :)
…ossos into chunk-save-actions
URL of deployed dev instance (used for testing):
Steps to test:
Issues: