Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

organization-specific newUserMailingList and overTimeMailingList #2939

Merged
merged 9 commits into from
Jul 23, 2018
Merged

organization-specific newUserMailingList and overTimeMailingList #2939

merged 9 commits into from
Jul 23, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 20, 2018 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • set up Mailer
  • set the two new field in the db to real email adresses
  • check if you get something

Issues:

@fm3 fm3 added this to the Sprint 25a milestone Jul 20, 2018
@fm3 fm3 self-assigned this Jul 20, 2018
@fm3 fm3 changed the title [WIP] add organization newUserMailingList organization-specific newUserMailingList and overTimeMailingList Jul 20, 2018
@fm3 fm3 requested review from normanrz and jstriebel July 20, 2018 12:51
@fm3
Copy link
Member Author

fm3 commented Jul 20, 2018

@normanrz how should this value be set? If we just apply the migration it’s emptystring for now. Should we add a note in migrations.md?

@fm3 fm3 mentioned this pull request Jul 20, 2018
Merged
1 task
normanrz
normanrz approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should get an entry in the migration guide that tells admins to move the value from config to database

@fm3 fm3 merged commit 81d919f into master Jul 23, 2018
@fm3 fm3 deleted the organization-mail branch July 23, 2018 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

@jstriebel jstriebel Awaiting requested review from jstriebel

Assignees

@fm3 fm3

Labels
backend enhancement
Projects
None yet
Milestone
Sprint 25a
Development

Successfully merging this pull request may close these issues.

Send new user email to organization email address
2 participants
@fm3 @normanrz