Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign user task list #2861

Merged
merged 12 commits into from
Jul 16, 2018
Merged

Redesign user task list #2861

merged 12 commits into from
Jul 16, 2018

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Jul 6, 2018

This PR replaces the user task list table with a list of "cards". This makes it easier to read the whole description of a task and doesn't break long project/task-type names. Let's wait for feedback and refine accordingly

URL of deployed dev instance (used for testing):

Steps to test:

  • Create and get some tasks, so the user task list is populated.
  • Check whether the user task list is rendered correctly, the description is fully readable and the actions still work.
  • The list with the finished tasks and the admin view for a users tasks (Users - Show Tracings) should look the same, but the description should be restricted in height, to allow for better readability when scanning many tasks.

Issues:


  • Ready for review

@jstriebel
Copy link
Contributor

jstriebel commented Jul 9, 2018

@daniel-wer: Please remember to add the change notes to the changelog ;)

@philippotto philippotto added this to the Sprint 24a milestone Jul 9, 2018
@philippotto philippotto changed the title Redesign user task list [Blocked] Redesign user task list Jul 9, 2018
@daniel-wer daniel-wer changed the title [Blocked] Redesign user task list Redesign user task list Jul 12, 2018
@daniel-wer daniel-wer requested a review from philippotto July 12, 2018 09:51
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Looks really good! I pushed some minor design tweaks, since I figured it would be faster than describing it here :)

Looks like this now:
image

@philippotto
Copy link
Member

Ok, now I see that Alexander wanted description and buttons switched around. I also took the liberty to do this 🙈

@daniel-wer
Copy link
Member Author

@philippotto Thanks for getting this PR finalized. I'll merge as soon as CI is done.

@daniel-wer daniel-wer merged commit e4f1cf8 into master Jul 16, 2018
@daniel-wer daniel-wer deleted the redesign-user-task-list branch July 16, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign user task list
3 participants