Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No four bit segmentation #2828

Merged
merged 4 commits into from
Jul 2, 2018
Merged

No four bit segmentation #2828

merged 4 commits into from
Jul 2, 2018

Conversation

philippotto
Copy link
Member

This PR ensures that segmentation data is never requested in four bit mode. Also, it changes the saving code for segmentation buckets so that the fourBit flag is not send along with the request, since that property is ignored by the server anyway.
This hopefully fixes #2811 as the only symptom we could reproduce on that is fixed with this PR.

I also merged the bucketbuilder file into the wkstore adapter since that file is only used for the wkstore anyway.

Mailable description of changes:

  • A bug which caused segmentation data to be requested as four-bit when four-bit-mode was enabled is fixed now.

URL of deployed dev instance (used for testing):

Steps to test:

  • test a normal dataset with and without four bit mode (ensure that data is loaded with the correct flag)
  • load a dataset with segmentation and ensure that segmentation is properly shown even in four-bit mode
  • repeat the last step while creating a new segmentation layer

Issues:


  • Ready for review

@philippotto philippotto self-assigned this Jun 29, 2018
@philippotto philippotto requested a review from daniel-wer June 29, 2018 06:58
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great that you added tests right away! Worked well, 🤞 that this fixes the volume tracing issues :)

@philippotto philippotto merged commit 0d72d3d into master Jul 2, 2018
@normanrz normanrz deleted the no-four-bit-segmentation branch July 2, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volume tracing data lost
2 participants