Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid suboptimal bucket loading sequence for initial loading of dataset #2749

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jun 14, 2018

Reuse bucket_picker priorities when requesting missing buckets via pullqueu

Mailable description of changes:

  • The order in which initial buckets are loaded when viewing a dataset was streamlined.

URL of deployed dev instance (used for testing):

Steps to test:

  • open tracing in ortho and arbitrary views. ensure that bucket loading order makes sense.
  • especially, initial loading should be from center to the outside

  • Ready for review

@philippotto philippotto self-assigned this Jun 14, 2018
@philippotto philippotto requested a review from daniel-wer June 14, 2018 12:51
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested, works very well 👍

@philippotto philippotto merged commit 72c65f5 into master Jun 14, 2018
@philippotto philippotto deleted the reuse-picker-priorities branch June 18, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants