Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refresh datasets for teammanagers #2688

Merged
merged 3 commits into from
Jun 7, 2018
Merged

Fix refresh datasets for teammanagers #2688

merged 3 commits into from
Jun 7, 2018

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Jun 6, 2018

Mailable description of changes:

  • Refreshing datasets now works for teamManagers too

Steps to test:

  • try to refresh datasets as teamManager -> should work

Issues:

  • Ready for review

@youri-k youri-k self-assigned this Jun 6, 2018
@youri-k youri-k requested review from fm3, jstriebel and rschwanhold June 6, 2018 07:35
fm3
fm3 approved these changes Jun 6, 2018
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fm3 fm3 merged commit 2c18a02 into master Jun 7, 2018
@fm3 fm3 deleted the dataset-refresh-button branch June 7, 2018 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

@jstriebel jstriebel Awaiting requested review from jstriebel

@rschwanhold rschwanhold Awaiting requested review from rschwanhold

Assignees

@youri-k youri-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Token authentication fails on datasets refresh button for non-admins
2 participants
@youri-k @fm3