Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the XSS vectors I've found during my recent webknossos security review. See https://docs.google.com/presentation/d/1zTBnoy3_lTsoBfMeOz96W3bnlUtvTv2qkXrKMiu326s/edit?usp=sharing
I've also replaced all unnecessary uses of <%= in Backbone (Lodash) templates with <%- (that html encodes strings).
Steps to test:
XSS Vector 1
<script>alert('xss')</script>
, login as another user and go to the overview page, select the team of the malicious user (and adjust the hours slider, so the user is displayed)XSS Vector 2
<script>alert('xss')</script>
and create a project belonging to the newly created team.Issues:
ATTENTION: Merging this PR may close #1685 as my commit message unfortunately contains the word fix :/ If so, please reopen the issue as it contains more ToDos.