-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support voxel size in other units than nm #6577
Comments
We would also have to decide if the internal float32 nm representation is still good enough. If so, this is a frontend-only issue. If we need very large voxel sizes, say, multiple meters (e.g. for geodata?), we would have to change the internal representation too (possibly storing the unit) to not lose precision. |
I think, storing the unit in addition to the scale would be a good approach. The migration would be easy (a missing
This would automatically fix/improve some things, such as:
|
Hi - this issue would include the ability to read units from e.g. OME-NGFF. |
Hmm, I feel like this should already work. Thanks for the report, we’ll have a look! |
@will-moore It looks like the multiscales metadata at https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0062A/6001240.zarr/.zattrs uses the keyword |
Whoa - Ooops! That looks like our mistake there... Checking the ngff repo I see that the schema uses "units": https://github.com/ome/ngff/blob/0a087b8319b234a0682bc4853e390314f76f7540/0.4/schemas/image.schema#L127 I guess the issue here is that having "unit" when the schema states "units" is not actually invalid, as the schema allows unknown keys to be added. Thanks for the pointer. |
With the sample at https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0062A/6001240.zarr fixed Thanks! |
I think we should revive this. |
Detailed Description
ATM, voxel size is defined in nm. While that is good default for high-resolution EM datasets, it is very impractical for MRI/CT dataset, light microscopy, and low-resolution, large FOV EM scans.
We should refactor the voxel size such that the actual unit does not matter as much as long as the ratio is correct, e.g., 150x150x300nm vs 150000x150000x300000nm (converted from um) == 15x15x30 .
Maybe the unit could be selected from a dropdown in the UI and wK does all the conversion internally.
This is also relevant for any work for correlative, multi-scale datasets. Related to #6085
Context
jobsEnabled=true
inapplication.conf
)isDemoInstance=true
inapplication.conf
)The text was updated successfully, but these errors were encountered: