You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking at the history of 0.4 and especially #57, I suspect the confusion comes from the fact that the initial implementation had a field called units and this got transformed into unit (specifically in 70ebede).
Although an units field is not invalid per se, the specification uses unit and I think our examples, our validation and generation tools should exclusively use this terminology. Related to the example above, I see a few places that should be updated:
As reported scalableminds/webknossos#6577 (comment)
some of our sample data uses
"units"
forv0.4 axes
when the spec says
"unit"
: https://ngff.openmicroscopy.org/latest/#axes-mdChecking the ngff repo I see that the schema uses "units":
ngff/0.4/schemas/image.schema
Line 127 in 0a087b8
whereas the example files use "unit"
https://github.com/ome/ngff/blob/main/0.4/examples/multiscales_strict/multiscales_example.json
and some of the test files use both! https://github.com/ome/ngff/blob/0a087b8319b234a0682bc4853e390314f76f7540/0.4/tests/strict_image_suite.json
I guess the issue here is that having "unit" when the schema states "units" is not actually invalid, as the schema allows unknown keys to be added.
The text was updated successfully, but these errors were encountered: