Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree names resetted in Project HS_AG_st122_wholeCells and other Projekts #1550

Closed
deployboy opened this issue Dec 7, 2016 · 15 comments
Closed
Assignees

Comments

@deployboy
Copy link

deployboy commented Dec 7, 2016

Good evening,

I noticed that all tree names of my project got resettet. They are now named "Tree001", "Tree002"... etc. where they used to have a unique Name identifier (including the last digets of the Task ID and a shortcut of the tracers name). With this issue it is impopssible to identify the Tasks corresponding to the traced tree in the "view all finished tasks" view.

Please rename the trees accordingly.

Thank you very much,
Raphael Jakoby

(Admin Team)

Reported by: Raphael Jakoby ([email protected]) on master

Log Time

@hotzenklotz
Copy link
Member

@daniel-wer Is there any chance this could have been caused by the name tree naming schema?

@daniel-wer
Copy link
Member

@tmbo This seems to be related to the backend change if I'm not mistaken?

@tmbo
Copy link
Member

tmbo commented Dec 8, 2016

Yes it is, but it is due to the fact that we decided to drop the renaming.
@heikowissler @manuel-berning

@manuel-berning
Copy link

Will talk to Raphael Jakoby and try to find a solution

@tmbo tmbo added the discussion label Dec 8, 2016
@manuel-berning
Copy link

Manuel Berning
10:41 AM
@raphael.jakoby @heiko.wissler: Sollten hier mal ueber die Treenames sprechen bei Zeiten
10:42
Raphael: Koenntest du ein bisschen mehr Kontext lieferen? Wann werden die Treenamen jetzt so angezeigt? (e.g. CompundProjectView, uploaded yourself?)
Raphael Jakoby
3:17 PM
Grüß dich Manuel . Mir ist das gestern zum ersten Mal aufgefallen, als ich alle gefinishten Tasks über die Ansicht "view all finished Tasks" in der Projektübersicht angesehen habe. Ich selbst habe dazu keine nmls hochgeladen. Wahrscheinlich ist das die CompundProjectView wie du schreibst?
Manuel Berning
3:18 PM
Ja so ist es
3:18
Liegt daran, dass ein Merge für verschiedene Skelette immer gleich ausgeführt wird
3:19
(e.g. beim Hochladen mehrer nml oder beim Anschauen aller Tasks eines Projektes)
3:19
das Problem was wir mit der bisherigen Taktik hatten ist das Dateinamen immer länger wurden
3:19
sry, Treenamen mein ich
Raphael Jakoby
3:20 PM
Betroffen sind mindestens 2 Projekte HS_AG_st122_wholeCells und HS_AG_st122_dendritesNoSoma aber wahrscheinlich mehrere..
Manuel Berning
3:20 PM
die wurden per default beim Erzuegen als "TreeXXX" festgelegt
3:20
ja alle
Raphael Jakoby
3:20 PM
hmm... ok und da habt ihr was geändert?
Manuel Berning
3:20 PM
ja genau wegen dem Problem oben
3:21
also wird koennten es einfach Aendern per Download -> Skript -> Upload
Raphael Jakoby
3:21 PM
Das Problem jetzt ist natürlich für admins, dass diese Ansicht mehr oder weniger nutzlos ist 😞 weil keine eindeutige Identifizierung mehr möglich ist.
Manuel Berning
3:21 PM
ja also das wird bei neuen Projekten jetzt nicht mehr passieren
3:21
weil da der Tree bei Erzugung gleich sinnvoll benannt wird
3:21
(nicht mehr TreeXXX)
3:22
sondern taskID_user oder so
Raphael Jakoby
3:22 PM
Das ist gut 🙂 und was kann für die alten Projekte getan werden?
3:22
klasse
Manuel Berning
3:22 PM
ja gute Frage
3:22
muss ich mal mit @heiko.wissler abklaeren
Raphael Jakoby
3:22 PM
Oki
Manuel Berning
3:22 PM
ich kann sie runterladen
3:22
ein Skript laufen lassen
3:22
wieder hochladen
3:23
dann sollte alle information wieder da sein
3:23
aber dann ist es ein Explorative Tracing und kein Projekt
3:23
ich frag mal Tom

What I wanted to ask: Would it be easily possible to rename all trees in the DB that match the pattern "TreeXXX" to the new naming scheme (e.g. what you currently put in the filename during download)? Any caveats? This is very similar to your proposed solution #2 here:
#1540
Only difference I would propose it do it once in the DB (and not on merge only for merged version)?
If this is involved I will do the download -> Rename scripts to some regexp of filename -> upload as explorative hack to solve this problem (which should not occur with new projects if I understood correctly).

@tmbo
Copy link
Member

tmbo commented Dec 8, 2016

@manuel-berning no I think that is actually a quite neat solution. So the format was
explorative_#data_#firstname_#lastname_#treeId and task_#taskId_#firstname_lastname_#treeId.

@manuel-berning from the top of your head, do you know if it is the complete taskId or the 6digit abbreviation?

@manuel-berning
Copy link

I the filename we always had the long version & I would prefer that.

Patterns look right except one missing "#" before lastname in the 2nd line. 😛 (and maybe the #data should be #date). Also Daniel mentioned #user which I think is first letter of first name followed by last name. Would of course be good to keep this consistent.

Mentioned in the PR by @daniel-wer

Open an explorational tracing. Create a new tree and check the tree tab. The tree naming should follow the format: explorative_date_user_#

Open a task. Create a new tree and check the tree tab. The tree naming should follow the format: task_taskId_user_#

BTW: Would this yield unique treenames? I think that would be the most important property for me.

@tmbo
Copy link
Member

tmbo commented Dec 8, 2016 via email

@tmbo
Copy link
Member

tmbo commented Dec 8, 2016

@manuel-berning The frontend will NOT use the user name as you mentioned. The current implementation daniel did is ... _#firstname_#lastname_ ... and not ... _#firstLetterFirstName#lastname.

Eg. it will be _tom_bocklisch_ and not _tbocklisch_

@manuel-berning
Copy link

Ok, thanks a lot!. Sounds to me as that would solve the problem Raphael (and other members of the admin team) currently have. @heikowissler: Do you have an opinion?
I would say you can go ahead and change this whenever you can find some time.

In general everything that is consistent is of course preferred, e.g. using a common definition of #user throughout, no matter whether back-end (generation of filenames for download I guess) or front-end (creating a new tree). Same is also true for short vs. long forms of IDs, which seem to vary throughout wK. But I guess you are aware of that yourselves.
Of course we can also handle these differences on our side for now, so a rather general comment & not urgent. I think we should only make sure that we have some sensible format here (which I think we do).

@tmbo
Copy link
Member

tmbo commented Dec 8, 2016

I am working on the script to change the names right now.

If we wan't to change the naming convention to _tbocklisch_ for trees, we should probably do it now.

@heikowissler
Copy link

heikowissler commented Dec 8, 2016 via email

@manuel-berning
Copy link

@tmbo: I think making the naming should be as consistent as possible (i think so far I mostly used the tbocklisch as that is in the downloaded .nml's so I would vote for that). @daniel-wer: Could you change the pattern for newly created trees accordingly? (Basically the renaming from Tom and the pattern during creation should be the same.

@tmbo
Copy link
Member

tmbo commented Dec 9, 2016

@heikowissler @manuel-berning so the script completed successfully and all trees have been renamed. For now with the naming scheme as it is implemented at the moment (i.e. ... _tom_bocklisch_ ...) we can still decide to change that. It's in easy one to rename the trees to that format as well.

@tmbo tmbo closed this as completed Dec 9, 2016
@manuel-berning
Copy link

Thanks will let Raphael Jakoby know.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants