Create node button creates node at wrong position

[tmbo]

Clicking the create node button moves the viewport to (x+1, y+1,z) and sets the point there. Point should be set at the current location.

Log Time

[hotzenklotz]

@tmbo @georgwiese Isn't the "create node" button supposed to "jump" around a little and never hit center. I believe someone wanted that once? But maybe I don't recall correctly.

[boergens]

That is correct.. Please remove the create node button from release.. it was only for the review branch

[tmbo]

I actually like the idea of having the button, since it makes the node setting easily discoverable and it would be an easy fix. But if you say it is unnecessary, I am happy about a cleaner interface as well :)

[boergens]

@tmbo I see the point and that was also why I pushed for it on review.. In a way the frontend has to accommodate a lot of different user types right now..
Well, "when in doubt do nothing", at least for now?

[tmbo]

Okay, sounds reasonable 😀 Let's fix the position so the node is at the expected location and keep everything else as is.

[boergens]

@tmbo well actually the position had an intention too
because we felt that only if there is an on-screen movement the effect would be obvious
but we could do it the other way round, first set node, then move

[tmbo]

Yes the other way around seems more reasonable to me. Let's

• First create Node and then move
• Make sure the position is updated correctly

[georgwiese]

I implemented this on add-node. However, I still find it counter-intuitive that an "Add Node" button changes the current position.

@kevinbbb87 We already highlight nodes after they got created (they grow in size for a second). Shouldn't this be enough visual feedback?

If you're worried that users might click multiple times and not realize that they created multiple nodes, we can check if the active node is at the new node's position. If yes, we could cancel the node creation or even show a toast message.

[boergens]

I'm open to deactivating the moving feature.. I liked it but if you feel it is counter-intuitive we can remove it. what do the others think?
Let's not cancel or toast the node creation though

[georgwiese]

Since there were no more comments, I removed the offset. It would be trivial to add it again if it becomes necessary.