Skip to content

Commit

Permalink
Filter webgl context loss / isTrusted errors (#7926)
Browse files Browse the repository at this point in the history
* filter webgl context loss / isTrusted errors

* fix that WebGLContextLost error should be logged instead of serialized isTrusted msg
  • Loading branch information
philippotto authored Jul 17, 2024
1 parent 9f2eb10 commit 98e70d5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions frontend/javascripts/libs/error_handling.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const BLACKLISTED_ERROR_MESSAGES = [
"Invariant Violation: Cannot call hover while not dragging.", // Errors from the sortable-tree when dragging an element onto itself
"Uncaught Invariant Violation: Expected to find a valid target.",
"Uncaught TypeError: Cannot read property 'path' of null",
"WebGLContextLost",
];
type ErrorHandlingOptions = {
throwAssertions: boolean;
Expand Down
2 changes: 1 addition & 1 deletion frontend/javascripts/oxalis/view/tracing_view.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const registerWebGlCrashHandler = (canvas) => {
key: WEBGL_CONTEXT_LOST_KEY,
});
console.error("Webgl context lost", e);
ErrorHandling.notify(e);
ErrorHandling.notify(new Error("WebGLContextLost"));
},
false,
);
Expand Down

0 comments on commit 98e70d5

Please sign in to comment.