Skip to content

Commit

Permalink
Only provide shortcut for tree search and not for comment search (#3407)
Browse files Browse the repository at this point in the history
* only support shortcut for tree search and not for comment search

* update changelog
  • Loading branch information
philippotto authored Nov 5, 2018
1 parent 9d23b75 commit 83e21ef
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.md).

- Fixed a layouting issue which occurred on a fresh page load when the layout was scaled to be bigger than the available space. [#3256](https://github.com/scalableminds/webknossos/pull/3256)
- Fixed overlap in comment tab for long tree names or comments. [#3272](https://github.com/scalableminds/webknossos/pull/3272)
- Fixed that CTRL + Shift + F opens two search popovers in the tracing view. Instead, the shortcut will only open the tree search now. [#3407](https://github.com/scalableminds/webknossos/pull/3407)
- Fixed a bug which caused data to not be displayed correctly if adjacent data does not exist.[#3270](https://github.com/scalableminds/webknossos/pull/3270)
- Fixed a bug which caused data to not be displayed correctly if adjacent data does not exist. [#3270](https://github.com/scalableminds/webknossos/pull/3270)
- Fixed a bug which caused initial rendering to sometimes miss some buckets. [#3262](https://github.com/scalableminds/webknossos/pull/3262)
- Fixed a bug which caused the save-button to never show success for volume tracings. [#3267](https://github.com/scalableminds/webknossos/pull/3267)
Expand Down
17 changes: 10 additions & 7 deletions app/assets/javascripts/oxalis/view/right-menu/search_popover.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ type Props<S> = {
idKey: $Keys<S>,
onSelect: number => void,
children: *,
provideShortcut?: boolean,
};

type State = {
Expand All @@ -35,13 +36,15 @@ export default class SearchPopover<S: Object> extends React.PureComponent<Props<

return (
<React.Fragment>
<Shortcut
supportInputElements
keys="ctrl + shift + f"
onTrigger={() => {
this.setState({ isVisible: true });
}}
/>
{this.props.provideShortcut ? (
<Shortcut
supportInputElements
keys="ctrl + shift + f"
onTrigger={() => {
this.setState({ isVisible: true });
}}
/>
) : null}
<Popover
title="Search"
trigger="click"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ class TreesTabView extends React.PureComponent<Props, State> {
idKey="treeId"
searchKey="name"
maxSearchResults={10}
provideShortcut
>
<Tooltip title="Open the search via CTRL + Shift + F">
<ButtonComponent>
Expand Down

0 comments on commit 83e21ef

Please sign in to comment.