Skip to content

Commit

Permalink
detect neuroglancer precomputed and n5 datasets as needsConversion=fa…
Browse files Browse the repository at this point in the history
…lse (#8008)

* detect neuroglancer precomputed and n5 datasets as needsConversion=false

* changelog
  • Loading branch information
fm3 authored and knollengewaechs committed Sep 2, 2024
1 parent bc5f278 commit 7d8180b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
- Fixed that the flood-filling action was available in the context menu although an editable mapping is active. Additionally volume related actions were removed from the context menu if only a skeleton layer is visible. [#7975](https://github.com/scalableminds/webknossos/pull/7975)
- Fixed that activating the skeleton tab would always change the active position to the active node. [#7958](https://github.com/scalableminds/webknossos/pull/7958)
- Fixed that skeleton groups couldn't be collapsed or expanded in locked annotations. [#7988](https://github.com/scalableminds/webknossos/pull/7988)
- Fixed uploading datasets in neuroglancer precomputed and n5 data format. [#8008](https://github.com/scalableminds/webknossos/pull/8008)

### Removed

Expand Down
9 changes: 6 additions & 3 deletions frontend/javascripts/admin/dataset/dataset_upload_view.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -556,11 +556,14 @@ class DatasetUploadView extends React.Component<PropsWithFormAndRouter, State> {
}

let needsConversion = true;
const fileBaseNames = fileNames.map((name) => name.split(/[\\/]/).pop());
if (
containsExtension("wkw") ||
containsExtension("zarray") ||
fileNames.includes("datasource-properties.json") ||
fileNames.includes("zarr.json")
containsExtension("zarray") || // zarr2
fileBaseNames.includes("datasource-properties.json") || // wk-ready dataset
fileBaseNames.includes("zarr.json") || // zarr 3
fileBaseNames.includes("info") || // neuroglancer precomputed
fileBaseNames.includes("attributes.json") // n5
) {
needsConversion = false;
}
Expand Down

0 comments on commit 7d8180b

Please sign in to comment.