Fix screenshot tests (#8289)

* fix screenshot tests * update screenshots * apply feedback --------- Co-authored-by: Michael Büßemeyer <[email protected]>
scalableminds · Dec 18, 2024 · 32257f1 · 32257f1
1 parent fe53375
commit 32257f1
Show file tree

Hide file tree

Showing 12 changed files with 5 additions and 3 deletions.
diff --git a/frontend/javascripts/test/puppeteer/dataset_rendering.screenshot.ts b/frontend/javascripts/test/puppeteer/dataset_rendering.screenshot.ts
@@ -1,3 +1,4 @@
+import urljoin from "url-join";
 import "test/mocks/lz4";
 import type { PartialDatasetConfiguration } from "oxalis/store";
 import path from "node:path";
@@ -27,7 +28,7 @@ process.on("unhandledRejection", (err, promise) => {
   console.error("Unhandled rejection (promise: ", promise, ", reason: ", err, ").");
 });
 const BASE_PATH = path.join(__dirname, "../../../../frontend/javascripts/test/screenshots");
-let URL = "https://master.webknossos.xyz";
+let URL = "https://master.webknossos.xyz/";
 
 if (!process.env.URL) {
   console.warn(
@@ -114,7 +115,8 @@ test.before("Retrieve dataset ids", async () => {
       3,
       async () => {
         const options = getDefaultRequestOptions(URL);
-        const url = `${URL}/api/datasets/disambiguate/sample_organization/${datasetName}/toId`;
+        const path = `/api/datasets/disambiguate/sample_organization/${datasetName}/toId`;
+        const url = urljoin(URL, path);
         const response = await fetch(url, options);
         const { id } = await response.json();
         datasetNameToId[datasetName] = id;
@@ -124,7 +126,7 @@ test.before("Retrieve dataset ids", async () => {
     );
   }
 });
-test("Dataset IDs were retrieved successfully", (t) => {
+test.serial("Dataset IDs were retrieved successfully", (t) => {
   for (const datasetName of datasetNames) {
     t.truthy(datasetNameToId[datasetName], `Dataset ID not found for "${datasetName}"`);
   }

diff --git a/frontend/javascripts/test/screenshots/2017-05-31_mSEM_aniso-test.png b/frontend/javascripts/test/screenshots/2017-05-31_mSEM_aniso-test.png
diff --git a/...end/javascripts/test/screenshots/2017-05-31_mSEM_scMS109_bk_100um_v01-aniso.png b/...end/javascripts/test/screenshots/2017-05-31_mSEM_scMS109_bk_100um_v01-aniso.png
diff --git a/frontend/javascripts/test/screenshots/ROI2017_wkw_fallback.png b/frontend/javascripts/test/screenshots/ROI2017_wkw_fallback.png
diff --git a/frontend/javascripts/test/screenshots/ROI2017_wkw_with_mapping_astrocyte.png b/frontend/javascripts/test/screenshots/ROI2017_wkw_with_mapping_astrocyte.png
diff --git a/frontend/javascripts/test/screenshots/annotation_ROI2017_wkw_fallback_null.png b/frontend/javascripts/test/screenshots/annotation_ROI2017_wkw_fallback_null.png
diff --git a/...d/javascripts/test/screenshots/annotation_ROI2017_wkw_fallback_segmentation.png b/...d/javascripts/test/screenshots/annotation_ROI2017_wkw_fallback_segmentation.png
diff --git a/frontend/javascripts/test/screenshots/connectome_file_test_dataset.png b/frontend/javascripts/test/screenshots/connectome_file_test_dataset.png
diff --git a/frontend/javascripts/test/screenshots/dsA_2.png b/frontend/javascripts/test/screenshots/dsA_2.png
diff --git a/frontend/javascripts/test/screenshots/float_test_dataset.png b/frontend/javascripts/test/screenshots/float_test_dataset.png
diff --git a/frontend/javascripts/test/screenshots/test-agglomerate-file_with_mapping_link.png b/frontend/javascripts/test/screenshots/test-agglomerate-file_with_mapping_link.png
diff --git a/frontend/javascripts/test/screenshots/test-agglomerate-file_with_meshes_link.png b/frontend/javascripts/test/screenshots/test-agglomerate-file_with_meshes_link.png