apply some coderabbit suggestions

scalableminds · Oct 24, 2024 · 1a3675f · 1a3675f
1 parent 034fe9e
commit 1a3675f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/frontend/javascripts/admin/api/token.ts b/frontend/javascripts/admin/api/token.ts
@@ -38,7 +38,7 @@ export async function doWithToken<T>(
   fn: (token: string) => Promise<T>,
   tries: number = 1,
   useURLTokenIfAvailable: boolean = true,
-): Promise<any> {
+): Promise<T> {
   let token =
     useURLTokenIfAvailable && shouldUseURLToken ? getSharingTokenFromUrlParameters() : null;
 

diff --git a/frontend/javascripts/libs/request.ts b/frontend/javascripts/libs/request.ts
@@ -312,7 +312,7 @@ class Request {
                 key: json.status.toString(),
               }));
               if (showErrorToast) {
-                Toast.messages(messages); // Toast.error already logs the error
+                Toast.messages(messages); // Note: Toast.error internally logs to console
               } else {
                 console.error(messages);
               }
@@ -324,9 +324,9 @@ class Request {
               return Promise.reject({ ...json, url: requestedUrl });
             } catch (_jsonError) {
               if (showErrorToast) {
-                Toast.error(text); // Toast.error already logs the error
+                Toast.error(text); // Note: Toast.error internally logs to console
               } else {
-                console.error(text);
+                console.error(`Request failed for ${requestedUrl}:`, text);
               }
 
               /* eslint-disable-next-line prefer-promise-reject-errors */