Skip to content

Commit

Permalink
Fix upload of bounding box only skeleton annotations (#6985)
Browse files Browse the repository at this point in the history
  • Loading branch information
frcroth authored Apr 17, 2023
1 parent c568213 commit 0c7385f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,14 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released

### Changed
- Moved the view mode selection in the toolbar next to the position field. [#6949](https://github.com/scalableminds/webknossos/pull/6949)
- Redesigned welcome toast for new, annonymous users with new branding. [#6961](https://github.com/scalableminds/webknossos/pull/6961)
- Redesigned welcome toast for new, anonymous users with new branding. [#6961](https://github.com/scalableminds/webknossos/pull/6961)

### Fixed
- Fixed unintended dependencies between segments of different volume layers which used the same segment id. Now, using the same segment id for segments in different volume layers should work without any problems. [#6960](https://github.com/scalableminds/webknossos/pull/6960)
- Fixed incorrect initial tab when clicking "Show Annotations" for a user in the user list. Also, the datasets tab was removed from that page as it was the same as the datasets table from the main dashboard. [#6957](https://github.com/scalableminds/webknossos/pull/6957)
- Fixed that unsaved changes were shown when opening an annotation, although there weren't any. [#6972](https://github.com/scalableminds/webknossos/pull/6972)
- Fixed misleading email about successful dataset upload, which was in some cases sent even for unusable datasets. [#6977](https://github.com/scalableminds/webknossos/pull/6977)
- Fixed upload of skeleton annotations with no trees, only bounding boxes, being incorrectly rejected. [#6985](https://github.com/scalableminds/webknossos/pull/6985)

### Removed

Expand Down
2 changes: 1 addition & 1 deletion app/models/annotation/nml/NmlParser.scala
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ object NmlParser extends LazyLogging with ProtoGeometryImplicits with ColorGener
}

val skeletonTracingOpt: Option[SkeletonTracing] =
if (treesSplit.isEmpty) None
if (treesSplit.isEmpty && userBoundingBoxes.isEmpty) None
else
Some(
SkeletonTracing(
Expand Down

0 comments on commit 0c7385f

Please sign in to comment.