Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff to cluster_tools #1023

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Add Ruff to cluster_tools #1023

merged 7 commits into from
Mar 21, 2024

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Mar 21, 2024

Description:

  • This PR adds ruff to the cluster tools sub-repo replacing black + isort as formatters and pylint as linter.
  • The ruff config is identical to webknossos-libs sub-repo.

Issues:

  • No issue

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Updated Documentation
  • Added / Updated Tests
  • Considered adding this to the Examples

@hotzenklotz hotzenklotz self-assigned this Mar 21, 2024
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good 👍


[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

[tool.isort]
profile = "black"
[tool.ruff]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a comment that links to webknossos/pyproject.toml (and vice versa), so that it's clear that potential future changes should be done at both places.

@hotzenklotz hotzenklotz marked this pull request as ready for review March 21, 2024 15:27
@hotzenklotz hotzenklotz merged commit 461257d into master Mar 21, 2024
34 checks passed
@hotzenklotz hotzenklotz deleted the clustertools_ruff branch March 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants