Sanitize layer names in from_images #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm3
reviewed
Mar 12, 2024
| assert _ALLOWED_LAYER_NAME_REGEX.match( | ||
| layer_name | ||
| ), f"The layer name '{layer_name}' is invalid. It must only contain letters, numbers, underscores, hyphens and dots." | ||
|
|
There was a problem hiding this comment.
could this also check the does-not-start-with-dort condition?
There was a problem hiding this comment.
Yes, the _ALLOWED_LAYER_NAME_REGEX checks that at least one allowed character that is not a dot has to be at the beginning of the string.
hotzenklotz
reviewed
Mar 12, 2024
hotzenklotz
approved these changes
Mar 14, 2024
fm3
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
add_layermethod and sanitizes the generated layer names offrom_images.Todos:
Make sure to delete unnecessary points or to check all before merging: