This repository has been archived by the owner on May 31, 2023. It is now read-only.
logout boss tokens on server shutdown #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm3
approved these changes
Mar 11, 2019
| await self.http_client.post(url, data=data) | ||
| del self.token_infos[key] | ||
| except ClientResponseError: | ||
| pass |
There was a problem hiding this comment.
Is this ClientResponseError harmless enough to just pass? Maybe add some logging?
There was a problem hiding this comment.
I would say so. The most common case this will happen will be that the token is expired, which I didn't want to check upfront, but rather simply except here. I'll add a comment to explain this.
Is this fine iyo? I can also add logging, but didn't want to clutter the output with stuff that won't harm too much anyway.
|
I don't think there is a session limit, this is rather just to clean up the tokens in the end, as it seems to be good practice. Most of the changes are refactorings anyways, only a couple of lines are actually needed for the logout. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #62