fix from_json, extract routes to files

[jstriebel]

This PR mainly extracts the routes into files, as the __main__.py grew too big, more routes are coming in the next PR. @fm3 What do you think about the file-structure?

Also, I noted a bug from the last PR, which I fixed here as well, see my comment at the code.

[jstriebel]

There is a bug in mypy version 0.670, which was just released:
python/mypy#6364

[fm3]

good catch!

[jstriebel]

Tuple type definitions are expected to specify all fields, or use the ellipsis, which is similar to lists then. This is needed to make from_json work for tuples of unknown length.

[fm3]

Why do we want tuples of unknown length instead of plain lists? Does that help with hashability/typechecking etc?

[jstriebel]

Exactly, tuples can be cached, lists not.

[jstriebel]

Also, I removed the add_dataset endpoint /api/<backend_name>/<organization_name>/<dataset_name>, which will be replaced by some logic on the upload route (POST on /data/datasets).

[fm3]

Route categories seem fine. However, I think I still prefer Play’s routes list files as they have all entry points in one overview, but I suppose that’s not so easy to recreate here. It’s also not a super strong preference.

[fm3]

good catch!

[fm3]

Why do we want tuples of unknown length instead of plain lists? Does that help with hashability/typechecking etc?

[jstriebel]

@fm3 Actually having something similar like the routes-files should be easy:

from .my_route import my_route
app.route("/bla/<param1>/<param2>", methods=["POST"])(my_route)

The problem here is that it's harder to see if the method's and the url's parameters match. That's why I would leave it like this for now.

[fm3]

True, fine by me to leave it :)