Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

remove uint64->uint32 conversion #139

Merged
merged 1 commit into from
Oct 24, 2022
Merged

remove uint64->uint32 conversion #139

merged 1 commit into from
Oct 24, 2022

Conversation

jstriebel
Copy link
Contributor

@jstriebel jstriebel commented Oct 24, 2022

Since we are now supporting uin64 (or sth. like uint53^^) in the frontend, we can and should send the whole data to it.

I'm not 💯% sure, how the datasource is handled in the different use-cases, but I think it was already presented as a uint64 dataset there, and the conversion just happened in the single place changed in this PR. I'll double check this.

The only place where uint64 was converted is the one in this change. In the datasource-properties the layer was already presented as uint64.

@fm3 @philippotto Would it be easy for you to test this change locally?

@jstriebel jstriebel requested review from fm3 and philippotto October 24, 2022 08:19
@jstriebel jstriebel self-assigned this Oct 24, 2022
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fm3 @philippotto Would it be easy for you to test this change locally?

Since the change is small and makes sense to me and because the uint64 support is currently broken, anyway, I'd say, let's just merge this. I'm confident that this will do the trick :)

@jstriebel jstriebel merged commit c324361 into master Oct 24, 2022
@jstriebel jstriebel deleted the actual-uint64 branch October 24, 2022 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants