Fix #9413: Fix test for user-defined equality #9414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
changed the title
smarter
reviewed
Jul 22, 2020
| @@ -23,13 +23,16 @@ class VCElideAllocations extends MiniPhase with IdentityDenotTransformer { | |||
| override def runsAfter: Set[String] = Set(ElimErasedValueType.name) | |||
|
|
|||
| override def transformApply(tree: Apply)(using Context): Tree = | |||
| def hasUserDefinedEquals(tp: Type): Boolean = | |||
| val eql = defn.Any_equals.overridingSymbol(tp.typeSymbol.asClass) | |||
| eql.exists && !eql.is(Synthetic) | |||
There was a problem hiding this comment.
Hmm, looks like vc-equals.scala is failing because we get a mixin forwarder equals in D, adding butNot = Bridge should fix that. Additionally, I think overridingSymbol only looks for symbols in the class itself since it calls matchingDecl, whereas we want matchingMember here.
odersky
added
the
fasttrack
|
Looks like it works now. Let's get it in! |
smarter
requested changes
Jul 23, 2020
I noted another useless boxing (in Positioned.scala), where we have ``` (new Span(x): Span).coord ``` The allocation should be eliminated but was not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test to determine whether value class has a user-defined equality