Fix #1441: init MODULE$ in <clinit> #9181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
changed the title
liufengyun
force-pushed
the
fix-1441b
branch
2 times, most recently
from
c86ca4d to
49d88a7
Compare
liufengyun
force-pushed
the
fix-1441b
branch
2 times, most recently
from
37fac7f to
6ca1b10
Compare
|
Good work! For generating super accessors you can use |
smarter
reviewed
Jul 18, 2020
sjrd
reviewed
Jul 21, 2020
smarter
reviewed
Jul 21, 2020
liufengyun
force-pushed
the
fix-1441b
branch
3 times, most recently
from
7c768a3 to
475ee8b
Compare
liufengyun
commented
Jul 22, 2020
smarter
requested changes
Jul 23, 2020
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9181/ to see the changes. Benchmarks is based on merging with master (0f1a23e) |
liufengyun
force-pushed
the
fix-1441b
branch
2 times, most recently
from
c794429 to
43c8159
Compare
This is a port of the following PR in Scala 2: scala/scala#3935
Otherwise, we will need to support trees like `C.this.$outer.super[D]` as in Scala 2, which complicates invariants about super.
Co-authored-by: Guillaume Martres <[email protected]>
We should check the type instead, which is more semantic.
Still we have a problem with the following magic: https://github.com/scala/scala/pull/7270/files#r221195225 It is a magic for two reasons: 1. It generates `getstatic` for `Select(This(O$), x)` 2. It is not affected by compilation order of classes For the second, suppose the backend compiles `A$B` before `A`. Then the class `A$B` does not see that `x` is static, which should cause problem at runtime: ``` object A { private[this] val x: Int = 10 class B { val y = x } } ``` The following are the reasons why it works in scalac: 1. inner classes always come after the outer class 2. non `private[this]` fields are accessed via accessor methods, which are not static 3. inside the module class, access to the fields are compiled after setting the static flag 4. the code generation specialize for trees like `Select(This(O$), x)`, where `x` is a static member
The magic in scalac is order-dependent: https://github.com/scala/scala/pull/7270/files#r221195225 See the previous commit for more detailed info.
There are compilation errors due to changes between 8 and 11 - addition of `String.lines` shadows the deprecated `StringOps.lines` in stdlib * probblem for ScalaTest - JAXB APIs are removed * problem for BetterFiles
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9181/ to see the changes. Benchmarks is based on merging with master (b8825a2) |
smarter
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1441: init $MODULE in
<clinit>Related: #5928 #8652