Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup BackendInterface #9099

Merged
merged 98 commits into from
Jun 9, 2020
Merged

Cleanup BackendInterface #9099

merged 98 commits into from
Jun 9, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jun 2, 2020 •
edited
Loading

In this PR we

  • Removed the BackendInterface
  • Made all internal types explicit
  • Inlined or moved most logic from DottyBackendInterface
  • Do not change any logic

Left for a future PR

  • Rearchitecture the state left in DottyBackendInterface

@nicolasstucki nicolasstucki self-assigned this Jun 2, 2020
@nicolasstucki
Remove Modifiers from BackendInterface
bc1225b
@nicolasstucki
Remove ModuleDef from BackendInterface
2368884
@nicolasstucki
Remove ApplyDynamic from BackendInterface
be3f4c3
@nicolasstucki
Remove implicit conversions from BackendInterface
615d670
@nicolasstucki
Rename BackendInterface extractors
05af70b
@nicolasstucki
Use DottyBackendInterface directly
401146a
@nicolasstucki
Remove BackendIntefaceDefinitions
ce74470
@nicolasstucki
Remove direct references to BackendInterface
9ae52fd
@nicolasstucki
Remove BackendInterface
a0bec05
@nicolasstucki
Remove classTags
d463644
@nicolasstucki
Remove custom extractors
e8edee9
@nicolasstucki
Remove more custom extractors
3226aca
@nicolasstucki
Remove aliases
9330317
@nicolasstucki
Remove more aliases
cec354c
@nicolasstucki
Remove custom Val/Def extractors
b0a2713
@nicolasstucki
Remove more custom extractors
c8cbf36
@nicolasstucki
Remove some aliases
bc6af84
@nicolasstucki
Remove constantHelper
cbad766
@nicolasstucki
Remove treeHelper
2fe7de6
@nicolasstucki
Remove extractor abstractions
e8c0609
@nicolasstucki
Remove nameHelper
d82ee36
@nicolasstucki
Remove positionHelper and annotHelper
2e8f5c5
@nicolasstucki
Remove aliases
f8dbf7c
@nicolasstucki
Remove custom ThrownException extractor
62bb744
@nicolasstucki
Remove some abstractions
cebc102
@nicolasstucki
Remove some abstractions
967cdea
@nicolasstucki
Remove helper methods
5298923
@nicolasstucki
Remove methods form typeHelper
9291854
@nicolasstucki nicolasstucki requested a review from smarter June 8, 2020 11:02
@smarter
Copy link
Member

smarter commented Jun 8, 2020 •
edited
Loading

@nicolasstucki I think you might have missed some of my comments: they're hidden in the github UI, you have to click "load more..." under "7 hidden conversations"

@nicolasstucki nicolasstucki requested a review from smarter June 8, 2020 14:52
@smarter smarter assigned nicolasstucki and unassigned smarter Jun 9, 2020
@liufengyun liufengyun mentioned this pull request Jun 9, 2020
Closed
@nicolasstucki nicolasstucki force-pushed the cleanup-backend-interface branch from 4bce5c7 to 3e36134 Compare June 9, 2020 15:46
@nicolasstucki
Copy link
Contributor Author

Indeed, I missed the hidden comments. Now I addressed all of them.

@smarter smarter merged commit 011b3a7 into scala:master Jun 9, 2020
@smarter smarter deleted the cleanup-backend-interface branch June 9, 2020 17:27
This was referenced Oct 19, 2020
Open
Closed
@bishabosha bishabosha mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
fasttrack Simple fix. Reviewer should merge or apply additional changes directly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @dottybot @smarter